Repository navigation
Conversation
…d data Import from Clipboard (and TSV file import) had two ways to lose data: - Values such as 00123, 0612345678 or 007 were inferred as INTEGER, so the created column dropped their leading zeros (ZIP codes, phone numbers, ids). A number with a leading zero is now inferred as TEXT; 0 itself and decimals like 0.5 stay numeric. - Excel and Google Sheets quote a copied cell that holds a line break, a tab or a quote, and double the quotes inside. The TSV parser split such a cell at its line break into separate rows and kept the quotes. It now reads a quoted field when the closing quote ends the cell (followed by a tab, a line break or the end); any other quote, as in 5" or "quoted" text, stays plain text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by claude-sonnet-5.5 · Input: 252 · Output: 2K · Cached: 227.6K Review guidance: REVIEW.md from base branch |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two ways Import from Clipboard (and
.tsvfile import, which uses the same parser) loses data:1. Leading zeros are dropped. ZIP codes, phone numbers and ids such as
00123,0612345678or007were inferred asINTEGER, so the created column stores123,612345678and7. A number with a leading zero is now inferred asTEXT.0itself and decimals like0.5are still numeric, and the type can still be changed in the dialog.2. Multi-line cells from a spreadsheet break the rows. Excel and Google Sheets quote a copied cell that holds a line break, a tab or a quote, and double the quotes inside it:
The TSV parser split on every line break, so this became two rows,
["Alice", "\"line 1"]and["line 2\""]. It now reads a quoted field when its closing quote ends the cell, meaning it's followed by a tab, a line break or the end of the text, and un-doubles"". Any other quote stays plain text, so5"and"quoted" textare unchanged. CRLF inside and between cells works too.Testing
tests/utils/clipboardParser.test.ts(6 new tests):TEXTwhile plain ids stayINTEGER;0and0.5staying numeric.pnpm typecheck✅, ESLint (no warnings) and Prettier on the changed files ✅.vitest run: 498 files, 8075 tests, all passing.AI assistance: found and written with Claude Code, tested as above.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.