Skip to content

Rename CYD 3248S035C vendor from CYD to Sunton#523

Closed
KenVanHoeylandt wants to merge 1 commit intomainfrom
cyd-rename-to-sunton
Closed

Rename CYD 3248S035C vendor from CYD to Sunton#523
KenVanHoeylandt wants to merge 1 commit intomainfrom
cyd-rename-to-sunton

Conversation

@KenVanHoeylandt
Copy link
Copy Markdown
Contributor

@KenVanHoeylandt KenVanHoeylandt commented Apr 13, 2026

Summary by CodeRabbit

  • Chores
    • Updated device board support configuration in build pipeline.
    • Updated device vendor metadata and configuration references.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 90c5db4a-f2da-4f8a-b2a5-625d013decd5

📥 Commits

Reviewing files that changed from the base of the PR and between 4dd2762 and 2b8da06.

📒 Files selected for processing (11)
  • .github/workflows/build.yml
  • Devices/sunton-3248s035c/CMakeLists.txt
  • Devices/sunton-3248s035c/Source/Configuration.cpp
  • Devices/sunton-3248s035c/Source/devices/Display.cpp
  • Devices/sunton-3248s035c/Source/devices/Display.h
  • Devices/sunton-3248s035c/Source/devices/SdCard.cpp
  • Devices/sunton-3248s035c/Source/devices/SdCard.h
  • Devices/sunton-3248s035c/Source/module.cpp
  • Devices/sunton-3248s035c/device.properties
  • Devices/sunton-3248s035c/devicetree.yaml
  • Devices/sunton-3248s035c/sunton,3248s035c.dts

📝 Walkthrough

Walkthrough

This pull request updates device identification and configuration from a "cyd-3248s035c" board to a "sunton-3248s035c" board. The changes span three areas: the CI/CD workflow now builds firmware for the renamed board, the device properties file updates the vendor name from CYD to Sunton, and the device tree configuration points to the updated device tree source file reference. These modifications reflect a consistent rebranding or renaming of the board identifier across the build system and device configuration files.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: renaming the vendor from CYD to Sunton for the 3248S035C device across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cyd-rename-to-sunton

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KenVanHoeylandt KenVanHoeylandt deleted the cyd-rename-to-sunton branch April 13, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant