Repository navigation
perf: asynchronously load inspector previews - #1537
Merged
Merged
Conversation
CyanVoxel
added
Type: QoL
2 of 8 tasks
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is targeting the
devbranch for release with Alpha v9.7.Summary
This PR asynchronously loads inspector previews and stats, and leverages pre-existing cached thumbnails as loading placeholders for images as well as fallback previews for unlinked files.
Images and audio files will use their cached thumbnails if available instead of a loading/default preview icon. Animated images will also show the cached thumbnail which should be the first frame of the animation. Videos don't use loading icons or cached thumbnails (since video thumbs are taken from the middle of the video) and instead will just remain blank until loaded. Fonts don't use cached thumbnails since their thumbnail variant is different from the full preview, and don't use loading icons because the full previews load very quickly. All stats should also load asynchronously and populate the stats area when ready.
The unlinked icon style isn't final, just something to work with for now before I update the icon and decide on a more readable style/approach for unlinked and ignored file icon overlays that also aren't confusing next to badges.
Closes #1389.
Tasks Completed