-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(router-core): Catch errors thrown during hydrate #5686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+708
−45
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
2e96440
fix: catch errors thrown in hydrate
roduyemi f9ee4a5
ci: apply automated fixes
autofix-ci[bot] a0796a6
Merge branch 'TanStack:main' into head-404-2
roduyemi 492a898
chore: update match.error and rethrow if not isNotFound
roduyemi b2eb15a
chore: remove test runs
roduyemi 0043a5c
chore(lint): Update imports in hydrate.test.ts
roduyemi cdf1237
chore: assert match.error equals isNotFound
roduyemi e6aad52
ci: apply automated fixes
autofix-ci[bot] 8f450d5
Merge branch 'main' into head-404-2
birkskyum b8bdcad
eslint import order
birkskyum 56819ef
fix: use string for notFound whitelist error
roduyemi b438321
use source file from react-router
birkskyum 761c209
Merge branch 'main' into head-404-2
birkskyum 52cb3e0
chore: move hydrate test to react-router
roduyemi 424fe83
chore: add hydrate test to solid-router
roduyemi 3bf6d41
chore: delete solid-router hydrate.test
roduyemi aa6ce57
fix: update to use package import
roduyemi 7aa3bb5
fix: package import order
roduyemi c6525e6
dont prerender notfound route
birkskyum 268b423
lint
birkskyum dad79fe
ci: apply automated fixes
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { createFileRoute, notFound } from '@tanstack/react-router' | ||
|
|
||
| export const Route = createFileRoute('/not-found/via-head')({ | ||
| head: () => { | ||
| throw notFound() | ||
| }, | ||
| component: RouteComponent, | ||
| notFoundComponent: () => { | ||
| return ( | ||
| <div data-testid="via-head-notFound-component"> | ||
| Not Found "/not-found/via-head"! | ||
| </div> | ||
| ) | ||
| }, | ||
| }) | ||
|
|
||
| function RouteComponent() { | ||
| return ( | ||
| <div data-testid="via-head-route-component" data-server={typeof window}> | ||
| Hello "/not-found/via-head"! | ||
| </div> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { createFileRoute, notFound } from '@tanstack/solid-router' | ||
|
|
||
| export const Route = createFileRoute('/not-found/via-head')({ | ||
| head: () => { | ||
| throw notFound() | ||
| }, | ||
| component: RouteComponent, | ||
| notFoundComponent: () => { | ||
| return ( | ||
| <div data-testid="via-head-notFound-component"> | ||
| Not Found "/not-found/via-head"! | ||
| </div> | ||
| ) | ||
| }, | ||
| }) | ||
|
|
||
| function RouteComponent() { | ||
| return ( | ||
| <div data-testid="via-head-route-component" data-server={typeof window}> | ||
| Hello "/not-found/via-head"! | ||
| </div> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.