docs(start): document route and asset base paths - #7882
whizzkid1452 wants to merge 2 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (2)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughAdds React and Solid guides for configuring asset and route prefixes. Adds navigation links to both guides. ChangesBase Paths Documentation
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The guides’ navigation and documented base-path behavior align with the runtime; no concrete merge risk is established. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/start/framework/react/guide/base-paths.md`:
- Around line 38-46: Update the base-paths documentation around the URL table to
define serverFns.base in the preceding configuration example, or explicitly
document its default value and how it combines with router.basepath for
server-function URLs. Ensure the table’s server-function prefix source is
understandable from the surrounding text.
In `@docs/start/framework/solid/guide/base-paths.md`:
- Around line 1-2: Update the Solid base-paths guide referenced by its
frontmatter so it no longer serves the React guide verbatim. Make the shared
explanation framework-neutral and replace React-specific configuration such as
`@tanstack/react-start/plugin/vite`, `@vitejs/plugin-react`, and viteReact() with
valid Solid-specific examples.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4dff169e-ef4e-4413-b9ca-3c9c6365acd8
📒 Files selected for processing (3)
docs/start/config.jsondocs/start/framework/react/guide/base-paths.mddocs/start/framework/solid/guide/base-paths.md
Summary
baseprefixes asset URLs while Startrouter.basepathprefixes application routes and server functions.Closes #4888
Test plan
pnpm test:docsdocs/start/config.jsonwithJSON.parseupstream/main(no affected projects for this documentation-only change)Summary by CodeRabbit