Repository navigation
feat(secrets): pick a team's secrets - #2942
Merged
Merged
Conversation
🎩 PreviewA preview build has been created at: |
This was referenced Oct 22, 2026
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
from
October 23, 2026 22:58
29a21da to
a49ef1e
Compare
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
from
October 23, 2026 23:50
a49ef1e to
b0456a0
Compare
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
2 times, most recently
from
October 27, 2026 00:59
a9c9dc5 to
d302051
Compare
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
from
October 27, 2026 17:33
d302051 to
7667ffa
Compare
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
2 times, most recently
from
October 28, 2026 23:11
d8b730c to
1e3fcb5
Compare
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
2 times, most recently
from
October 29, 2026 02:42
b500b7f to
5fc6a20
Compare
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
from
October 29, 2026 19:45
5fc6a20 to
0fbc39d
Compare
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
2 times, most recently
from
October 29, 2026 20:42
3fe8c5e to
3a81b79
Compare
camielvs
commented
Oct 29, 2026
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
from
October 29, 2026 23:33
3a81b79 to
3d68cb2
Compare
camielvs
commented
Oct 30, 2026
This was referenced Oct 30, 2026
camielvs
commented
Oct 30, 2026
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
2 times, most recently
from
October 30, 2026 18:51
0064b22 to
dfb1d9a
Compare
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
from
October 30, 2026 20:35
dfb1d9a to
0477f0b
Compare
camielvs
marked this pull request as ready for review
October 30, 2026 21:23
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
from
October 30, 2026 21:46
0477f0b to
c8b9fee
Compare
maxy-shpfy
approved these changes
Oct 30, 2026
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
from
October 30, 2026 23:50
c8b9fee to
ad2c18b
Compare
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
from
October 31, 2026 00:08
ad2c18b to
c4eef6c
Compare
In a team's project, the secret picker now offers the team's secrets alongside your own, so a secret picked for an argument is one the run can reach at launch, whoever it's submitted as. - Opened from a task argument in either editor, the picker uses the page's team (`useActingTeam`): the Tangent project of the embedded editor, or `?projectId=` in the standalone one. It resolves only while open, so an editor with many argument rows doesn't look up the team for each. - Opened from the submit dialog, it uses the team of the projects that run will be filed under, which the dialog now receives from its caller. `TangleSubmitter` gets it from the chosen project plus the page's scope, and `RunPipelineButton` from the project it runs in, both through the new `useTeamForSubmission`. `useActingTeam` is now that hook applied to the page's linked project. - Your secrets and the team's are listed apart, each under its own heading. "Add Secret" saves to your own by default. When you can write to the team, a "Save to" choice can put the new secret in the team's instead, so a pipeline built in the editor for a team's project can get a team secret without going through Tangent. - When the project has a team you can't act as, the picker says why and offers your own secrets, which are what the run will use. For projects on different teams it offers nothing. `ActingTeamNotice` holds that copy so the submit dialog can say the same thing later. It names the workspace with its icon, so `InfoBox` titles now accept rich content. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The picker's "The {workspace} workspace's secrets" heading now writes
the workspace's name with its icon inline, like the Secrets window.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
camielvs
force-pushed
the
cvs/pick-team-secrets
branch
from
October 31, 2026 00:12
c4eef6c to
cefb7df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In a team's project, the secret picker now offers the team's secrets alongside your own, so a secret picked for an argument is one the run can reach at launch, whoever it's submitted as.
useActingTeam): the Tangent project of the embedded editor, or?projectId=in the standalone one. It resolves only while open, so an editor with many argument rows doesn't look up the team for each.TangleSubmittergets it from the chosen project plus the page's scope.RunPipelineButtongets it from the project it runs in. Both use the newuseTeamForSubmission, anduseActingTeamis now that hook applied to the page's linked project.ActingTeamNoticeholds that copy so the submit dialog (feat(runs): submit as yourself or as the project's team #2943) can say the same thing. It names the workspace with its icon, soInfoBoxtitles now accept rich content.Related Issue and Pull requests
Type of Change
Line Breakdown
Checklist
Screenshots (if applicable)
None yet.
Test Instructions
With the same setup as #2941:
?projectId=). The result is the same.Additional Comments
None.
🤖 Generated with Claude Code