Repository navigation
Fix editor upgrade affordances and user-facing copy - #2960
Merged
Merged
Conversation
🎩 PreviewA preview build has been created at: |
camielvs
commented
Oct 27, 2026
camielvs
force-pushed
the
cvs/editor-polish-bugs
branch
4 times, most recently
from
October 29, 2026 21:22
de1290e to
ff223f8
Compare
Mbeaulne
reviewed
Oct 29, 2026
Mbeaulne
left a comment
Mbeaulne
left a comment
Collaborator
There was a problem hiding this comment.
🤖 This is an AI-generated code review comment.
AI-assisted review, posted by Mbeaulne. Comments only, not an approval.
2 findings on this PR: 1 medium, 1 low. Each comment says in plain English what breaks and why, then how to test it, with the technical breakdown collapsed.
Two things that don't belong on one line:
- Tests: the new "Review tasks" routing and the new alert in the Component Search window have no tests. The PR adds tests only for the shortcut label and the error-message wording.
- Existing review: the only earlier review on this PR (5675577052, an AI-generated comment posted from the author's account) is a word-for-word copy of the #2956 review and says nothing about this PR's changes.
camielvs
force-pushed
the
cvs/editor-polish-bugs
branch
4 times, most recently
from
October 30, 2026 01:47
fcd2758 to
57915df
Compare
maxy-shpfy
approved these changes
Oct 30, 2026
camielvs
force-pushed
the
cvs/editor-polish-bugs
branch
from
October 30, 2026 15:47
57915df to
7c5cd26
Compare
"Review tasks" picked the new-editor flow only when the details dialog was rendered inside a window, so opening it from a task card on the canvas fell back to the legacy overlay flow, which does nothing in the new editor. Key the choice on the new editor's shared store instead. Render the upgrade alert in Component Search directly; that window always has window context and the alert box already branches on it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The new editor's keyboard store treated Alt (and the Windows key) as the primary modifier on Windows/Linux, so Ctrl+Z, Ctrl+C and the other shortcuts did nothing there while the rest of the app, the Learn tips and the shortcut badges all said Ctrl. Map the primary modifier to Cmd on Mac and Ctrl elsewhere. Off Mac, shortcuts declared with Ctrl share that key, so Ctrl+O and Ctrl+Shift+M keep working. Badges go back to "Ctrl", and Ctrl shows as the Control symbol on Mac. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The primary shortcut modifier is now Cmd on Mac and Ctrl elsewhere, so the old name no longer describes it. No behavior change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Default layout and Duplicate were both registered on Cmd/Ctrl+D, and the registry keeps one handler per combo, so which one the key ran depended on mount order. The Learn tip promises that Cmd/Ctrl+D duplicates the selection. Also update the tips that still described the old Alt modifier. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The shortcuts map deep-converted each definition into an observable copy, so unregister's identity check never matched and shortcuts stayed registered after their owner unmounted, still running stale handlers. Store definitions as-is. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add review tasks button and upgrade components flow back to v2 editor
Summary
search_componentstool name in missing-implementation errors with user-facing “component search” copyTests