Skip to content

Ready Up: Abstraction for external use#46

Open
jensewe wants to merge 5 commits into
masterfrom
readyup
Open

Ready Up: Abstraction for external use#46
jensewe wants to merge 5 commits into
masterfrom
readyup

Conversation

@jensewe

@jensewe jensewe commented May 17, 2023

Copy link
Copy Markdown
Collaborator

Major features:

  • Now other plugins can create custom ready-up phases via native StartCustomReadyUp.
    • Built for nothing but "pause" plugin.
  • More forwards to control the flow of ready-up.
  • Support for survival mode.

Fix:

  • Fixed team ready being broken.

jensewe added 4 commits May 17, 2023 17:52
Feature:
- New phrases to translate ready panels. (EN, CHI for now)
- New ConVar "l4d_ready_swap_footers" to swap locations of command footers and native footers on panel.

Fix:
- Fixed load failure for double registering "IsPlayerReady".
- Fixed playing secret effects when unready.

Change:
- Shortened window for afk detection from 15.0s to 7.7s :)
@PaaNChaN

PaaNChaN commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

hello forgetest.
when do you expect to pull this pull request?
i want to add it to my server :)

@jensewe

jensewe commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator Author

hello forgetest. when do you expect to pull this pull request? i want to add it to my server :)

I think it's ready to go in terms of the basic functionalities, but there are a few problems regarding the custom ready feature that I recently have no time to deal with. Not so long but not short either, perhaps after half a month I will be back on it as well as the pause refactoring.

@PaaNChaN

PaaNChaN commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

I think it's ready to go in terms of the basic functionalities, but there are a few problems regarding the custom ready feature that I recently have no time to deal with. Not so long but not short either, perhaps after half a month I will be back on it as well as the pause refactoring.

thank you for your response.
im not sure about the custom ready feature.
can it be used as long as it is a normal readyup?
(ready per number of people & team ready)

@jensewe

jensewe commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator Author

To be honest, I didn't test since I don't have my folk to ready on the other team, but nothing in ready checking has changed literally. Please let me know if you find anything wrong.

Somehow replying to email doesn't work smh

@blueblur0730

Copy link
Copy Markdown
Contributor

It seems that currently readyup dosen't support coop mode... I made a little change to make it possible. If you don't mind it I would like to create a pull request if this change dosen't affect your current work... :)

@jensewe

jensewe commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator Author

It seems that currently readyup dosen't support coop mode... I made a little change to make it possible. If you don't mind it I would like to create a pull request if this change dosen't affect your current work... :)

Sure. I was stuck at some issues for quite a lot of time and it really feels like my passion on this has gone.

@nikita1824

nikita1824 commented Dec 8, 2023

Copy link
Copy Markdown

Hello, recently added this version of readyup on servers.
Here is the note for future updates just in case.
I was getting errors about invalid timer handle when timer forward should be fired, as it turned out, timer handle was deleted in the same timer forward (unfortunately, didn't save the log).

4 << 3 << 2 << 1

Hope this information will be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants