Merged
Conversation
seorang42
reviewed
Feb 10, 2025
| if (!PERMITTED_URL.ROLE_ADMIN.includes(originUrl)) router.replace('/member-management') | ||
| } else { | ||
| if (!PERMITTED_URL.UNKNOWN.includes(originUrl)) router.push('/login') | ||
| if (!PERMITTED_URL.UNKNOWN.includes(originUrl)) router.replace('/login') |
Contributor
There was a problem hiding this comment.
pw-check와 edit-information은 replace로 잘 변경해주신 것 같은데,
이 부분과 login으로의 replace는 다시 한 번 생각해봐야 할 것 같습니다.
예를 들어 권한이 없는 페이지로 url 입력을 통해 직접 이동하여 위 코드에서 replace가 된다면,
뒤로가기를 눌렀을 때 replace 된 페이지가 아닌 잘못된 페이지로 계속 뒤로가기가 되어
결국 다시 replace가 되는 상황이 생길 수 있을 것 같습니다.
이 부분에 대해서는 내일 프론트엔드끼리 상의 후 맞춰봐야 할 것 같습니다.
일단은 이대로 머지 부탁드립니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 티켓 넘버
📝작업 내용
🏞️스크린샷 (선택)
💬리뷰 요구사항(선택)