fix: wrong cobblemon apricorn texture paths#29
Open
hudsonm62 wants to merge 3 commits into
Open
Conversation
They probably were in earlier versions, but the texture path for apricorn logs are incorrect and was causing null textures Changing model textures to `"cobblemon:block/wood/*"` fixes issue TeamMidnightDust#21 https://gitlab.com/cable-mc/cobblemon/-/tree/main/common/src/main/resources/assets/cobblemon/textures/block/wood
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Round Trees to v8.3 by correcting Cobblemon apricorn log model texture paths and reflecting the change in metadata and changelog.
Changes:
- Bump pack description version from 8.2 to 8.3
- Fix Cobblemon apricorn log / stripped apricorn log model texture paths to use
cobblemon:block/wood/... - Add v8.3 entry to the changelog
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pack.mcmeta | Updates displayed pack version to 8.3 |
| input/assets/cobblemon/models/block/apricorn_log.json | Points model textures to cobblemon:block/wood/... |
| input/assets/cobblemon/models/block/stripped_apricorn_log.json | Points model textures to cobblemon:block/wood/... |
| assets/cobblemon/models/block/apricorn_log.json | Points model textures to cobblemon:block/wood/... |
| assets/cobblemon/models/block/stripped_apricorn_log.json | Points model textures to cobblemon:block/wood/... |
| CHANGELOG.md | Documents the texture-path fix in v8.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "min_format": 15, | ||
| "max_format": 255, | ||
| "description": "§2Version 8.2\n§e©Motschen 2026 | MIT Licence" | ||
| "description": "§2Version 8.3\n§e©Motschen 2026 | MIT Licence" |
Author
|
that should make copilot happy 😆 |
Author
|
@Motschen I would appreciate a review at your earliest convenience :) its been tested in both major supported versions of Cobblemon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They probably were in much earlier versions, but the texture path for apricorn logs/stripped logs are incorrect and was causing null textures as seen in #21
Changing model textures to
"cobblemon:block/wood/*"fixes #21Reference
https://gitlab.com/cable-mc/cobblemon/-/tree/main/common/src/main/resources/assets/cobblemon/textures/block/wood
Tested Result
Note: tested in both 1.20.1 and 1.21.1
--
FYI was unsure if I was supposed to edit the
./input/assetstoo, but I did anyway as I would like to get this merged asap -- perhaps a contributing guide would be nice for future potential maintainers!