Allow custom hints in XGUI for time parameters - #224
Conversation
Time arguments can be used for things other than ban lengths, but having it like this would always show the hint in XGUI of "Ban Length:".
XGUI now sets its hint for time arguments based on the parameter's hint, rather than a hardcoded "Ban Length:" value.
|
I'm a bit unsure on this way of handling it. While it is a quick fix, it causes a bit of a problem when it comes to text-based vs XGUI interactions with parameter hints. With this, you can either keep parameter hints in the same format they currently are, which looks good for text-based usage, but doesn't look good in XGUI; or you can use a format better suited for XGUI, which looks bad in text-based usages. What I would like to do is to create a whole new option here called something like |
|
With the change I'm proposing here, for |
Currently, if you use a param with time strings allowed, the hint in XGUI will always appear as "Ban Length:". This is fine for the default ULX uses of this, where it's only used by
ulx banandulx banid, but it doesn't make sense for other uses that aren't involving bans. This PR changes this to use the param'shintif it has one, or "Time:" if it doesn't.