Skip to content

fix: validate filtered vote responses - #236

Open
ShiroKSH wants to merge 1 commit into
TeamUlysses:masterfrom
ShiroKSH:fix/vote-approval-validation
Open

fix: validate filtered vote responses#236
ShiroKSH wants to merge 1 commit into
TeamUlysses:masterfrom
ShiroKSH:fix/vote-approval-validation

Conversation

@ShiroKSH

@ShiroKSH ShiroKSH commented Jul 8, 2026

Copy link
Copy Markdown

Summary

  • restrict filtered ULX votes to the players that were sent the vote
  • shorten admin approval votes from 30000 seconds to 30 seconds
  • skip the final votekick if the target left during approval

Why

Filtered votes are used for admin approval after successful votemap, votekick, and voteban votes. The server only sent those votes to the approving admin, but any client could still run ulx_vote 1 manually and have the response counted.

The approval timeout also used 30000, which is interpreted as seconds and could block new votes for over eight hours.

Checks

  • git diff --check
  • manual review of public vote and filtered approval call sites

@ShiroKSH
ShiroKSH marked this pull request as ready for review July 8, 2026 22:09
@ShiroKSH

Copy link
Copy Markdown
Author

@Nayruden - could you take a look at the filtered vote-response validation in this PR when you have a chance, or route it to the right reviewer? I can make any requested changes or add tests. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant