fix: validate filtered vote responses - #236
Open
ShiroKSH wants to merge 1 commit into
Open
Conversation
ShiroKSH
marked this pull request as ready for review
July 8, 2026 22:09
Author
|
@Nayruden - could you take a look at the filtered vote-response validation in this PR when you have a chance, or route it to the right reviewer? I can make any requested changes or add tests. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Filtered votes are used for admin approval after successful votemap, votekick, and voteban votes. The server only sent those votes to the approving admin, but any client could still run
ulx_vote 1manually and have the response counted.The approval timeout also used
30000, which is interpreted as seconds and could block new votes for over eight hours.Checks
git diff --check