Skip to content

fix: guard crash-prone runtime paths#237

Open
ShiroKSH wants to merge 1 commit into
TeamUlysses:masterfrom
ShiroKSH:fix/runtime-crash-guards
Open

fix: guard crash-prone runtime paths#237
ShiroKSH wants to merge 1 commit into
TeamUlysses:masterfrom
ShiroKSH:fix/runtime-crash-guards

Conversation

@ShiroKSH

@ShiroKSH ShiroKSH commented Jul 8, 2026

Copy link
Copy Markdown

Summary

  • avoid a nil optional-argument crash in ulx ent
  • reject dedicated-server-console use of ulx jailtp before reading player position
  • re-check stale players/state in delayed ragdoll and maul callbacks
  • fix malformed log color validation so bad cvar data is rejected

Why

These paths can be reached during normal admin usage or delayed callbacks after a player has disconnected or a state has ended. The changes add narrow guards without changing command permissions, target selection, damage, jail, ragdoll, or maul behavior.

Checks

  • git diff --check
  • manual review of touched call sites

@ShiroKSH
ShiroKSH marked this pull request as ready for review July 8, 2026 22:09
@ShiroKSH

Copy link
Copy Markdown
Author

@Nayruden - could you take a look at the runtime crash guards in this PR when you have a chance, or route it to the right reviewer? I can make any requested changes or add tests. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant