fix(android): use equals() instead of == for string comparison in Deserializer#4552
fix(android): use equals() instead of == for string comparison in Deserializer#4552hobostay wants to merge 1 commit intoTencent:mainfrom
Conversation
…erializer In Deserializer.java, `key == "null"` uses reference equality which fails when the string is deserialized from binary format (not interned). Changed to `"null".equals(key)` to correctly compare string values. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Test User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hi, @hobostay. Thanks for your PR! 👏 🏷️ You can leave a comment in this PR with |
|
After a quick scan, I have approved workflow to run. Details
🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators. |
Summary
key == "null"to"null".equals(key)inDeserializer.java(lines 242, 266)==operator checks reference equality, not value equality==comparison with the literal"null"would always failnullkey handling logic to never trigger, potentially leading to incorrect map deserializationTest plan
"null"string key correctly pushes a null key to the HippyMap/HippyArray🤖 Generated with Claude Code