Conversation
Signed-off-by: Gout999 <gout999@users.noreply.github.com>
Collaborator
|
Thank you so much for your attention and contribution! We will arrange an internal review for this PR shortly, and all feedback will be shared right here in the discussion. |
Gout999
marked this pull request as ready for review
August 23, 2026 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #995 with a low-risk identity configuration fallback for the Hermes plugin.
initialize()now resolves team, agent, and user IDs in this order: explicit functionarguments, environment variables, then the legacy defaults. The README documents the
optional
MEMORY_TENCENTDB_TEAM_ID,MEMORY_TENCENTDB_AGENT_ID, andMEMORY_TENCENTDB_USER_IDsettings and recommends configuring a migratedagt-...agent explicitly.
This is a partial mitigation: it does not implement lazy API list/create/discovery.
Verification
python3 -m py_compile MemoryCore/hermes-plugin/memory/memory_tencentdb/__init__.pygit diff --checkSigned-off-by: Gout999 gout999@users.noreply.github.com