test: implement unit tests for core lifecycle (12 stubs)#359
Open
Koan-Bot wants to merge 1 commit intoTest-More:2.0from
Open
test: implement unit tests for core lifecycle (12 stubs)#359Koan-Bot wants to merge 1 commit intoTest-More:2.0from
Koan-Bot wants to merge 1 commit intoTest-More:2.0from
Conversation
Replaces all 12 stub tests (skip_all "write me") with real unit tests covering the instance orchestrator, run/job management, runner lifecycle, and test configuration modules. Modules tested: - Test2::Harness::Client (abstract base, send_and_get, error path) - Test2::Harness::Instance (required attrs, api_ping/pid/log_file, handle_request success/error, parse_request_args, terminate first-reason-wins) - Test2::Harness::Instance::Message (attributes, TO_JSON with class field) - Test2::Harness::Instance::Request (required attrs, inheritance, TO_JSON) - Test2::Harness::Instance::Response (required attrs, undef response, success()) - Test2::Harness::Run (required attrs, aggregator_use_io alt, set_ipc/ipc, TO_JSON excludes internal fields, data_no_jobs) - Test2::Harness::Run::Job (auto job_id, try(), resource_id(), TO_JSON, process_info) - Test2::Harness::Runner (required attrs, ready(), stages(), terminate first-reason-wins) - Test2::Harness::Runner::Preloading (blacklist, terminate, preload_retry_delay) - Test2::Harness::Runner::Preloading::Stage (attributes, terminate overwrites) - Test2::Harness::TestFile (file validation, HARNESS directives, check_feature/duration/category) - Test2::Harness::TestSettings (defaults, includes, merge, propagate_false, load_import) Fixes Test-More#326 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
@exodist I let you validate before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements all 12 stub test files (previously
skip_all "write me") for the Test2::Harness core lifecycle modules — the instance orchestrator, run/job management, runner execution, and test settings.Fixes #326
Changes
send_and_getsuccess/failure paths,pingdelegationapi_ping/api_pid/api_log_file,handle_requestsuccess and error paths,parse_request_args(scalar/array/hash),terminatefirst-reason-wins semanticsTO_JSONincludesclassfieldTO_JSONexistscheck for undef response),success()booleanaggregator_use_ioalternative,set_ipc/ipcround-trip,TO_JSONexcludes internal fields,data_no_jobsjob_id,try()counts results,resource_id(),TO_JSON,process_infoexcludes private fieldsready()/stages()/stage_sets(),terminatefirst-reason-wins,killblacklistadd/query,terminatefirst-reason-wins,preload_retry_delaydefaultterminateoverwrites (no first-reason-wins — matches implementation)check_featuredefaults,set_duration/set_categoryincludeswith lib/blib/tlib flags,merge(later wins, dedup arrays, merge hashes),propagate_falsefor fork/preload,set_env_vars,load_importUUID/MemUsage pluginsTest plan
perl -Ilib <file>: no failuresIS_WIN32Generated by Kōan /fix
Quality Report
Changes: 1364 files changed, 103424 insertions(+), 24661 deletions(-)
Code scan: 224 issue(s) found
.gitignore:40— TODO commentREADME:607— TODO commentREADME:611— TODO commentREADME:615— TODO commentREADME.md:565— TODO commentREADME.md:569— TODO commentREADME.md:573— TODO commentdemo/tiny/tiny.t:4— XXX markerdeplib/App/Yath/Option.pm:21— FIXME commentdeplib/App/Yath/Options.pm:22— FIXME commentTests: failed (FAILED)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline