-
Notifications
You must be signed in to change notification settings - Fork 71
Working Exercise Tracker #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
chrisjamiecarter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @adityavaidya108 👋,
First of all, amazing job on your exercise tracker project submission! 🎉 It’s clear you’ve put a lot of effort into this, and you should take great pride in it.
I have performed a peer review and have added some bespoke comments where relevant.
I haven't got a lot to comment on really. Your project was a delight to review.
🟠 Style Guide Compliance
Remember that when you have finished a project, give it a polish pass. Refer to the C# Academy's code-conventions page for it's code style guidelines.
I would say that the majority of you code is perfectly fine, there was just some code walls in places that could do with a bit of blank line separation to aid readability.
🟠 No README File
At this point in your projects, every submission should include a README.md file.
You should intro your app. Detail setup (connection strings / ports), features, technologies. Note your challenges and lessons learned. Celebrate your successes and improvements.
Feel free to reach out if you have any questions or if you'd like to collaborate further on any of these points 🆘 .
I will go ahead and mark as approved, keep up the excellent work on the next projects! 😊
Best regards,
@chrisjamiecarter 👍
| @@ -0,0 +1,10 @@ | |||
| namespace ExerciseTracker.ASV.Models; | |||
|
|
|||
| public class ExerciseData | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Code Duplication
💡 I noticed that this is the same class that is in your Db project. Any reason? Could you have created a domain / entity project and stored common classes there?
|
@chrisjamiecarter Thank you so much for reviewing! 🙏 I will keep your points in mind for future projects. 🚀 |
No description provided.