Skip to content

fix: error handling and UI adjustment, removed "flutter version manag… #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCodeDaniel merged 1 commit into from
Mar 13, 2025
Merged

fix: error handling and UI adjustment, removed "flutter version manag… #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{
"dart.lineLength": 120,
"dart.flutterSdkPath": ".fvm/versions/3.27.1"
}
"dart.lineLength": 120
}
10 changes: 7 additions & 3 deletions lib/features/event_sockets/presentation/screens/event_sockets_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,15 +126,19 @@ class _EventSocketsViewState extends State<EventSocketsView> {
Icon(Iconsax.warning_2, color: Colors.amber),
Text(
"Check your socket parameters before connecting to websocket",
style: TextStyle(fontStyle: FontStyle.italic, fontWeight: FontWeight.bold),
style: TextStyle(fontWeight: FontWeight.bold),
),
],
),
Container(
width: size.width * 0.4,
height: size.height * 0.2,
height: size.height * 0.3,
padding: EdgeInsets.symmetric(horizontal: 20),
color: Colors.grey.shade200,
decoration: BoxDecoration(
color: Colors.grey.shade300,
borderRadius: BorderRadius.circular(10),
border: Border.all(color: Colors.grey.shade400),
),
child: JsonEditorTheme(
themeData: JsonEditorThemeData(lightTheme: JsonTheme.light()),
child: JsonEditor.object(
Expand Down
9 changes: 8 additions & 1 deletion lib/features/wsprotocol/data/repository/wsprotocol_repo_impl.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,14 @@ class WsprotocolRepoImpl {
},
onError: (error) {
// Forward errors to listeners.
_messageController.addError(error);
// _messageController.addError(error);
// Extract error message
final String errorMessage = error is WebSocketChannelException
? 'WebSocket Error: ${error.inner}'
: 'Unknown WebSocket Error: $error';

// Forward a structured error message
_messageController.addError(errorMessage);
},
onDone: () {
// Optionally notify listeners that the connection has closed.
Expand Down