ci: build multi-platform Rust binaries in the deploy job - #462
Merged
Conversation
Upload linux/macOS/Windows host-native CLI artifacts alongside the existing JAR and source archive. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
The release build of rust should add config like: Should improve the perf more(maybe not, but they're common release parameters in rust commmunity) |
The deploy and release jobs built //:bazel-diff-rust and then reproduced Bazel's own knowledge in shell: which path rules_rust writes the binary to (bazel-bin/src/bazel-diff vs .exe), what to rename it to per runner, and which C++ flags a release build needs. The rename in particular was unchecked -- a macOS runner would happily publish a binary named "linux-amd64". Move all of that into Bazel. //release:bazel-diff-rust selects on @platforms//os and @platforms//cpu to name its output for the platform it is built for, so the workflows now run one `bazelisk build ... --config=release` and upload what lands in bazel-bin/release/ -- no cp, no path branching, and `if-no-files-found: error` turns a name mismatch into a failed job. The build flags move to a `release` config in .bazelrc, which also drops the `--cxxopt=-std=c++17` the Windows leg was passing to MSVC (the platform configs in .bazelrc already send /std:c++17 there). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rules_rust does not read Cargo profiles, so `-c opt` alone gave the published binaries opt-level=3/debuginfo=0/strip=debuginfo -- no LTO and a full symbol table -- while Cargo.toml has declared `[profile.release] lto = "thin", strip = true` all along. Anyone building with cargo got a better binary than the one we ship. Add both to --config=release. On macOS arm64 the artifact drops from 6,344,496 to 5,304,656 bytes (-16.4%); //:rust_tests passes under the config. -Cstrip=symbols goes through extra_rustc_flags rather than the toolchain's strip_level so it applies to release builds only, and rules_rust appends it after the toolchain's own -Cstrip, where last-wins. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The Windows deploy leg failed with "invalid package name '/release'": Git bash's MSYS runtime treats an argument starting with //release as a UNC-ish Windows path and rewrites it to /release before Bazel ever sees it. The label this replaced, //:bazel-diff-rust, has no path-like segment after the slashes, so it was never converted -- the mangling only showed up once the target moved into a package. MSYS2_ARG_CONV_EXCL='//' excludes exactly the label arguments from conversion and leaves the rest of the command line alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The Windows leg has never built the Rust binary -- it failed the same way on this PR's first commit, before the //release target existed, so the label fix only got far enough to expose it. link.exe is MAX_PATH-bound at 260, and under Bazel's default Windows output root the Rust stdlib rlib C:\users\runneradmin\_bazel_runneradmin\<hash>\execroot\_main\bazel-out\ x64_windows-opt-exec-<hash>\bin\external\rules_rust++rust+rw-<n>_tools\ rust_toolchain\lib\rustlib\x86_64-pc-windows-msvc\lib\ librustc_std_workspace_alloc-e9a7af2889795557.rlib comes to 263 characters, so the link dies with LNK1181. Every rlib opened before it has a shorter file name and fits; that one is the first over. --output_user_root=C:/b shortens the prefix by 35 characters. It has to be a startup flag, so it rides in a matrix entry rather than --config=release. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployjob into a Linux/macOS/Windows matrix that builds and uploads the same host-native Rust CLI assets used by GitHub Releasesrelease.tar.gzartifacts on Ubuntu onlyTest plan
deploymatrix runs on ubuntu/macOS/windowsbazel-diff_deploy.jarrelease.tar.gzbazel-diff-rust-linux-amd64bazel-diff-rust-macos-arm64bazel-diff-rust-windows-amd64.exe--helpon their platformsMade with Cursor