feat(rocketchat): support alias/emoji/avatar overrides and client TLS config - #1741
Open
mdiniz97 wants to merge 4 commits into
Open
feat(rocketchat): support alias/emoji/avatar overrides and client TLS config#1741mdiniz97 wants to merge 4 commits into
mdiniz97 wants to merge 4 commits into
Conversation
…S config Rocket.Chat incoming webhooks accept alias/emoji/avatar overrides and may sit behind an internally-issued certificate, so extend the provider's config and Send() to cover both.
Adds Validate/Send scenarios for the new fields and a GetConfig test for group override merging, following the mattermost provider's test shape.
Adds rocketchat to both alerting YAML parsing tests so the provider is exercised alongside the others already covered there.
… override caveat Confirmed working against a live Rocket.Chat server per TwiN#1223 (comment), so drop the untested-provider warning. Also documents that Rocket.Chat ignores the channel override unless "Allow to overwrite destination channel in the body parameters" is enabled on the incoming webhook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the existing Rocket.Chat alerting provider (config/type registration was already scaffolded) with:
channel,alias,emoji,avataroverrides, matching Rocket.Chat's incoming webhook payload fieldsclientconfig (reusing the sharedclient.Config), so a webhook behind an internal/self-signed CA can be reached viaclient.insecure: truerocketchatalongside the other providers already covered inconfig_test.goalerting.rocketchat, including the untested-provider warning removal (confirmed working per discussion #1223) and a note that Rocket.Chat ignores thechanneloverride unless "Allow to overwrite destination channel in the body parameters" is enabled on the incoming webhook integrationTest plan
go build ./...go vet ./...go test ./alerting/provider/rocketchat/... -vgo test ./config/... -v -run Alerting