Skip to content

Bug: Remove artifacts directory created by dart-runner v>0.96 in the directory where bags are placed #123

Merged
HafeezOJ merged 3 commits into
mainfrom
120-bug-artifacts-directory-created-in-the-directory-where-bags-are-placed
Aug 27, 2025
Merged

Bug: Remove artifacts directory created by dart-runner v>0.96 in the directory where bags are placed #123
HafeezOJ merged 3 commits into
mainfrom
120-bug-artifacts-directory-created-in-the-directory-where-bags-are-placed

Conversation

@HafeezOJ
Copy link
Copy Markdown
Collaborator

@HafeezOJ HafeezOJ commented Aug 27, 2025

Description

dart-runner versions greater than 0.96 create an "_artifacts' directory in addition to the .tar file for a bag in the output_dir. The "_artifacts" directory contains only the metadata files in .txt format. Compared to dart-runner 0.96, the later versions also return a slightly different data structure and keys after successfully processing a bag, thereby creating a KeyError. Regardless of the KeyError, bags are generated successfully, but bagger reports errors after a run. This PR removes the "_artifacts" folder and fixes the KeyError, hence bagger will be able to use dart-runner 0.96 or greater.

Fixes

  • Remove "_artifacts" directory after creating the .tar file.
  • Consider differences in keys and structure returned by different dart-runner versions after successfully processing an item.

Testing (if applicable)

Run ReBACH using dart-runner 0.97. The test is passed if .tar file is created and "_artifacts" directory is not in output_dir. Also, KeyErrors should not occur.

@HafeezOJ HafeezOJ self-assigned this Aug 27, 2025
@HafeezOJ HafeezOJ linked an issue Aug 27, 2025 that may be closed by this pull request
1 task
@HafeezOJ HafeezOJ requested a review from zoidy August 27, 2025 18:20
@HafeezOJ HafeezOJ added the bug Something isn't working label Aug 27, 2025
@HafeezOJ HafeezOJ merged commit a7a21f8 into main Aug 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: artifacts directory created in the directory where bags are placed

2 participants