Avoid infinite loop on ProtoTree removal when corrupted - #53
Merged
bebopagogo merged 1 commit intoAug 28, 2026
Merged
Conversation
sleepybishop
changed the title
sleepybishop
force-pushed
the
fix-issue-70
branch
from
August 12, 2026 14:20
6b2d5d5 to
e7a5242
Compare
sleepybishop
force-pushed
the
fix-issue-70
branch
from
August 21, 2026 15:09
e7a5242 to
32a5e23
Compare
sleepybishop
marked this pull request as ready for review
August 21, 2026 15:13
bebopagogo
approved these changes
Aug 28, 2026
Collaborator
|
Thanks for the improvement here. I think this is a worthwhile safety measure even if it doesn't address the issue in the NORM code that highlights this. I think case there may be some race condition I haven't gotten my head around yet (I did try to replicate the reported problem but couldn't). Since it's occurring during shutdown in that case, this fix/improvement will avoid the infinite loop problem there. I hope to eventually track down the root cause there. I may use some of the new "tools" to analyze how that situation might be occurrring |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents an infinite loop in ProtoTree when keys are corrupted, fixing issue USNavalResearchLaboratory/norm#70