Add smart card support#45
Draft
thecristidima wants to merge 1 commit intochore/fix_cherrypick_conflicts_3.16from
Draft
Add smart card support#45thecristidima wants to merge 1 commit intochore/fix_cherrypick_conflicts_3.16from
thecristidima wants to merge 1 commit intochore/fix_cherrypick_conflicts_3.16from
Conversation
mihainradu
reviewed
Nov 14, 2025
| { | ||
| context->settings->SmartcardLogon = TRUE; | ||
| context->settings->PasswordIsSmartcardPin = TRUE; | ||
| context->settings->RedirectSmartCards = TRUE; |
Collaborator
There was a problem hiding this comment.
is this needed when it is localhost?
mihainradu
reviewed
Nov 14, 2025
| DWORD* choice, BOOL gateway) -> BOOL | ||
| { | ||
| auto res = false; | ||
| auto containerName = ConvToUtf16(instance->context->settings->ContainerName); |
Collaborator
There was a problem hiding this comment.
just note, rdpOptions->smartcardSettings.ContainerName is already utf16
also I would make this callback a decalared/named method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work-in-progress, it depends on the upgrade to FreeRDP 3 (we can consider it part 3) - see this PR first #44.
Added smart card support from FreeRDP. Changes required to create a session:
freerdp_connectwill returnTRUEbut the session won't be created unless it's loadedinstance->ChooseSmartcardfor cases where a user has multiple certificates; Robot.Session already finds the smart card certificate to validate the logon credentials, so we'll just have to pass the container name to the wrapper.Known issues: