fix: support tools with arguments named "self" #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way
StructuredToolis implemented, it will fail if the tool is supposed to take an argument namedself, because of its special convention in Python, even if the function is perfectly valid. See issue. This is very relevant for MCP and IS tools, where the user has little control over the argument names.As a fix on our side, we can extend
StructuredTooland override the problematic_run()and_arun()methods, only renaming the conventionalselfparam to an unconventional name, to reduce chances of collision.Added tests that:
BaseUiPathStructuredTool.