refactor(SimplifyEvaluatorCreation): simplify evaluator creation #1245
+21
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
test:uipath-langchain
akshaylive
commented
Feb 1, 2026
| @staticmethod | ||
| def _create_contains_evaluator(data: dict[str, Any]) -> ContainsEvaluator: | ||
| evaluator_id = data.get("id") | ||
| if not evaluator_id or not isinstance(evaluator_id, str): |
Collaborator
Author
There was a problem hiding this comment.
This check is redundant as evaluators have "id" as a required str field
akshaylive
force-pushed
the
akshaya/simply_evaluator_creation
branch
from
929f2bf to
1cda93f
Compare
mjnovice
reviewed
Feb 2, 2026
mjnovice
approved these changes
Feb 2, 2026
akshaylive
force-pushed
the
akshaya/simply_evaluator_creation
branch
from
1cda93f to
ad15af0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.