Skip to content

fix: hidden continue button on multisite setup wizard complete step (#842) #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superdav42 merged 2 commits into from
Apr 14, 2026
+70 −31
Merged

fix: hidden continue button on multisite setup wizard complete step (#842) #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3002bf3
fix: replace missing Tailwind classes with WP button classes on multi…
superdav42 Apr 14, 2026
ce1ac4b
Merge remote-tracking branch 'origin/main' into feature/auto-20260414…
superdav42 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 29 additions & 31 deletions inc/admin-pages/class-multisite-setup-admin-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,13 +216,13 @@ public function get_network_configuration_fields() {
],
'subdomain_recommendation' => [
'type' => 'note',
'desc' => '<div class="wu-bg-blue-50 wu-border wu-border-blue-200 wu-rounded-lg wu-p-4">
'desc' => '<div class="wu-bg-blue-100 wu-border wu-border-blue-500 wu-rounded-lg wu-p-4">
<div class="wu-flex">
<div class="wu-flex-shrink-0">
<span class="dashicons dashicons-info wu-text-blue-500"></span>
</div>
<div class="wu-ml-3">
<h4 class="wu-text-sm wu-font-medium wu-text-blue-800">' . esc_html__('Sub-domains are recommended for most businesses', 'multisite-ultimate') . '</h4>
<h4 class="wu-text-sm wu-font-medium wu-text-blue-700">' . esc_html__('Sub-domains are recommended for most businesses', 'multisite-ultimate') . '</h4>
<p class="wu-text-sm wu-text-blue-700 wu-mt-1">' . esc_html__('Sub-domains (e.g. site1.yourdomain.com) allow custom domain mapping and look more professional. Sub-directories (e.g. yourdomain.com/site1) are simpler to set up but cannot be changed later without rebuilding your network.', 'multisite-ultimate') . '</p>
</div>
</div>
Expand Down Expand Up @@ -319,28 +319,27 @@ public function section_complete(): void {

if ('success' === $result || is_multisite()) :
?>
<div class="wu-bg-green-50 wu-border wu-border-green-200 wu-rounded-lg wu-p-4 wu-mb-6">
<div class="wu-flex">
<div class="wu-flex-shrink-0">
<span class="dashicons dashicons-yes-alt wu-text-green-500"></span>
</div>
<div class="wu-ml-3">
<h4 class="wu-text-sm wu-font-medium wu-text-green-800">
<?php esc_html_e('Success!', 'multisite-ultimate'); ?>
</h4>
<p class="wu-text-sm wu-text-green-700 wu-mt-1">
<?php esc_html_e('WordPress Multisite has been successfully enabled. You can now continue with the Multisite Ultimate setup.', 'multisite-ultimate'); ?>
</p>
</div>
<div class="wu-bg-green-100 wu-border wu-border-green-300 wu-rounded-lg wu-p-4 wu-mb-6">
<div class="wu-flex">
<div class="wu-flex-shrink-0">
<span class="dashicons dashicons-yes-alt wu-text-green-500"></span>
</div>
<div class="wu-ml-3">
<h4 class="wu-text-sm wu-font-medium wu-text-green-800">
<?php esc_html_e('Success!', 'multisite-ultimate'); ?>
</h4>
<p class="wu-text-sm wu-text-green-700 wu-mt-1">
<?php esc_html_e('WordPress Multisite has been successfully enabled. You can now continue with the Multisite Ultimate setup.', 'multisite-ultimate'); ?>
</p>
</div>
</div>
</div>

<div class="wu-flex wu-justify-center">
<a href="<?php echo esc_url(wu_network_admin_url('wp-ultimo-setup')); ?>" class="wu-inline-flex wu-items-center wu-px-6 wu-py-3 wu-border wu-border-transparent wu-text-base wu-font-medium wu-rounded-md wu-text-white wu-bg-blue-600 hover:wu-bg-blue-700 wu-transition-colors">
<?php esc_html_e('Continue to Multisite Ultimate Setup', 'multisite-ultimate'); ?>
<span class="dashicons dashicons-arrow-right-alt wu-ml-2"></span>
</a>
</div>
<div class="wu-flex wu-justify-center">
<a href="<?php echo esc_url(wu_network_admin_url('wp-ultimo-setup')); ?>" class="button button-primary button-large">
<?php esc_html_e('Continue to Multisite Ultimate Setup', 'multisite-ultimate'); ?>
</a>
</div>
<?php
else :
$this->display_manual_instructions();
Expand Down Expand Up @@ -425,9 +424,9 @@ protected function display_manual_instructions(): void {
);
?>
</p>
<div class="wu-bg-gray-50 wu-border wu-border-gray-200 wu-rounded-lg wu-p-4 wu-mb-4">
<pre class="wu-text-sm wu-overflow-x-auto"><code class="wu-p-0"><?php echo esc_html($wp_config_constants); ?></code></pre>
</div>
<div class="wu-bg-gray-100 wu-border wu-border-gray-200 wu-rounded-lg wu-p-4 wu-mb-4">
<pre class="wu-text-sm wu-overflow-x-auto"><code class="wu-p-0"><?php echo esc_html($wp_config_constants); ?></code></pre>
</div>
</div>

<?php if (got_url_rewrite()) : ?>
Expand All @@ -438,19 +437,19 @@ protected function display_manual_instructions(): void {
<p class="wu-text-gray-600 wu-mb-4">
<?php esc_html_e('Replace the existing WordPress rules in your .htaccess file with:', 'multisite-ultimate'); ?>
</p>
<div class="wu-bg-gray-50 wu-border wu-border-gray-200 wu-rounded-lg wu-p-4 wu-mb-4">
<pre class="wu-text-sm wu-overflow-x-auto"><code><?php echo esc_html($htaccess_rules); ?></code></pre>
</div>
<div class="wu-bg-gray-100 wu-border wu-border-gray-200 wu-rounded-lg wu-p-4 wu-mb-4">
<pre class="wu-text-sm wu-overflow-x-auto"><code><?php echo esc_html($htaccess_rules); ?></code></pre>
</div>
</div>
<?php endif; ?>

<div class="wu-bg-blue-50 wu-border wu-border-blue-200 wu-rounded-lg wu-p-4 wu-mb-6">
<div class="wu-bg-blue-100 wu-border wu-border-blue-500 wu-rounded-lg wu-p-4 wu-mb-6">
<div class="wu-flex">
<div class="wu-flex-shrink-0">
<span class="dashicons dashicons-info wu-text-blue-500"></span>
</div>
<div class="wu-ml-3">
<h4 class="wu-text-sm wu-font-medium wu-text-blue-800">
<h4 class="wu-text-sm wu-font-medium wu-text-blue-700">
<?php esc_html_e('Next Steps', 'multisite-ultimate'); ?>
</h4>
<p class="wu-text-sm wu-text-blue-700 wu-mt-1">
Expand All @@ -461,9 +460,8 @@ protected function display_manual_instructions(): void {
</div>

<div class="wu-flex wu-justify-center">
<a href="<?php echo esc_url(admin_url('admin.php?page=wp-ultimo-multisite-setup&step=complete')); ?>" class="wu-inline-flex wu-items-center wu-px-4 wu-py-2 wu-border wu-border-transparent wu-text-sm wu-font-medium wu-rounded-md wu-text-white wu-bg-green-600 hover:wu-bg-green-700 wu-transition-colors">
<a href="<?php echo esc_url(admin_url('admin.php?page=wp-ultimo-multisite-setup&step=complete')); ?>" class="button button-primary button-large">
<?php esc_html_e('Refresh and Check Again', 'multisite-ultimate'); ?>
<span class="dashicons dashicons-update wu-ml-1"></span>
</a>
</div>
<?php
Expand Down
41 changes: 41 additions & 0 deletions tests/WP_Ultimo/Admin_Pages/Multisite_Setup_Admin_Page_Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,6 +659,25 @@ public function test_section_complete_runs_without_error(): void {
$this->assertIsString($output);
}

/**
* section_complete() button uses visible WP button classes, not missing Tailwind ones.
*
* wu-bg-blue-600 is not compiled into framework.css and caused the button to be
* rendered with white text on a transparent/white background (invisible). The fix
* replaces it with standard WP 'button-primary' classes which are always styled.
*/
public function test_section_complete_button_uses_wp_button_classes_not_missing_tailwind(): void {

// In test env is_multisite() is true, so the success branch renders.
ob_start();
$this->page->section_complete();
$output = ob_get_clean();

$this->assertStringContainsString('button-primary', $output, 'Continue button must use WP button-primary class');
$this->assertStringNotContainsString('wu-bg-blue-600', $output, 'wu-bg-blue-600 is not in framework.css and must not be used');
$this->assertStringNotContainsString('wu-bg-blue-700', $output, 'wu-bg-blue-700 is not in framework.css and must not be used');
}

// -------------------------------------------------------------------------
// display_manual_instructions() — via reflection
// -------------------------------------------------------------------------
Expand Down Expand Up @@ -713,6 +732,28 @@ public function test_display_manual_instructions_outputs_step_1_heading(): void
$this->assertStringContainsString('wp-config.php', $output);
}

/**
* display_manual_instructions() refresh button uses WP button classes, not missing Tailwind ones.
*
* wu-bg-green-600 is not compiled into framework.css, causing the "Refresh and
* Check Again" button to be invisible (white text on transparent background).
* The fix replaces it with standard WP 'button-primary' classes.
*/
public function test_display_manual_instructions_button_uses_wp_button_classes(): void {

$reflection = new \ReflectionClass($this->page);
$method = $reflection->getMethod('display_manual_instructions');
$method->setAccessible(true);

ob_start();
$method->invoke($this->page);
$output = ob_get_clean();

$this->assertStringContainsString('button-primary', $output, 'Refresh button must use WP button-primary class');
$this->assertStringNotContainsString('wu-bg-green-600', $output, 'wu-bg-green-600 is not in framework.css and must not be used');
$this->assertStringNotContainsString('wu-bg-green-700', $output, 'wu-bg-green-700 is not in framework.css and must not be used');
}

// -------------------------------------------------------------------------
// Wizard_Admin_Page inherited methods
// -------------------------------------------------------------------------
Expand Down
Loading