Skip to content

CHANGE: Test PR#2193

Closed
jdiehlUnity wants to merge 1 commit into
developfrom
test-dev
Closed

CHANGE: Test PR#2193
jdiehlUnity wants to merge 1 commit into
developfrom
test-dev

Conversation

@jdiehlUnity
Copy link
Copy Markdown
Collaborator

Description

Please fill this section with a description what the pull request is trying to address and what changes were made.

Testing status & QA

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity:
  • Halo Effect:

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@unity-cla-assistant
Copy link
Copy Markdown

unity-cla-assistant commented Jun 11, 2025

CLA assistant check
All committers have signed the CLA.

@jdiehlUnity jdiehlUnity marked this pull request as ready for review June 11, 2025 16:59
@jdiehlUnity jdiehlUnity changed the title Test PR CHANGE: Test PR Jun 11, 2025
@codecov-github-com
Copy link
Copy Markdown

codecov-github-com Bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2193      +/-   ##
===========================================
- Coverage    67.81%   67.78%   -0.03%     
===========================================
  Files          367      367              
  Lines        53513    53513              
===========================================
- Hits         36288    36276      -12     
- Misses       17225    17237      +12     
Flag Coverage Δ
mac_2021.3_pkg 5.41% <ø> (ø)
mac_2021.3_project 70.42% <ø> (ø)
mac_2022.3_pkg 5.19% <ø> (ø)
mac_2022.3_project 65.29% <ø> (ø)
mac_6000.0_pkg 5.20% <ø> (ø)
mac_6000.0_project 67.71% <ø> (ø)
mac_6000.1_pkg 5.20% <ø> (ø)
mac_6000.1_project 67.71% <ø> (-0.02%) ⬇️
mac_6000.2_pkg 5.20% <ø> (ø)
mac_6000.2_project 67.71% <ø> (ø)
mac_trunk_pkg 5.20% <ø> (ø)
mac_trunk_project 67.71% <ø> (ø)
win_2021.3_pkg 5.42% <ø> (ø)
win_2021.3_project 70.49% <ø> (ø)
win_2022.3_pkg 5.20% <ø> (ø)
win_2022.3_project 65.36% <ø> (ø)
win_6000.0_pkg 5.20% <ø> (ø)
win_6000.0_project 67.78% <ø> (+0.10%) ⬆️
win_6000.1_pkg 5.20% <ø> (ø)
win_6000.1_project 67.78% <ø> (-0.01%) ⬇️
win_6000.2_pkg 5.20% <ø> (ø)
win_6000.2_project 67.78% <ø> (ø)
win_trunk_pkg 5.20% <ø> (ø)
win_trunk_project 67.78% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...utsystem/InputSystem/Plugins/XR/GenericXRDevice.cs 87.87% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants