CHANGE: Re-enable tvOS tests in CI#2197
Closed
Pauliusd01 wants to merge 9 commits into
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2197 +/- ##
===========================================
+ Coverage 68.15% 68.16% +0.01%
===========================================
Files 367 367
Lines 53661 53661
===========================================
+ Hits 36572 36578 +6
+ Misses 17089 17083 -6
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Pauliusd01
changed the title
Collaborator
|
@Pauliusd01 do we still want this to be merged? |
Collaborator
Author
I think I was spooked by iOS failures (back when it wasn't clear It's an instability) but it might be fine to merge, will take another look a bit later |
Pauliusd01
changed the title
Collaborator
Author
|
The tests are still timing out occasionally, I'm gonna put this one back into the backlog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TvOS tests were unstable and disabled for a fairly long time, the code causing the instabilities is fixed by UUM-72211. So It should be fine to re-enable them. ISX-2144
Testing status & QA
Re-ran the tests a few times without failure
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: