FIX: add com.unity.polyspatial.extensions to DependantsToIgnoreInPreviewApv#2215
Merged
Conversation
Collaborator
|
I don't understand the problem this fixes. Can you clarify?
"Where" does it throw compile errors? Is it in our repo or somewhere else? |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2215 +/- ##
===========================================
+ Coverage 68.10% 68.11% +0.01%
===========================================
Files 367 367
Lines 53602 53602
===========================================
+ Hits 36505 36511 +6
+ Misses 17097 17091 -6
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
jfreire-unity
approved these changes
Aug 5, 2025
Collaborator
jfreire-unity
left a comment
There was a problem hiding this comment.
Approved based on Slack convo, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A preview version of com.unity.polyspatial.extensions currently throws compile errors. Adding it to a list of package to ignore during our own APV as advised by RM.
Testing status & QA
Overall Product Risks
Low.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: