FIX: Impossibility to set InputSystemUIInputModule.localMultiPlayerRoot to null

[hannem-rythmos]

Description

Case ISXB-1610] (https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1610)

This PR removes the null check in MultiplayerEventSystem.InitializePlayerRoot() that prevented setting InputSystemUIInputModule.localMultiPlayerRoot to null. We found that the check was introduced in PR #1547, but no specific reason was provided

Since localMultiPlayerRoot is already safely used (e.g., in IsMoveAllowed() via its own null check), we have removed the null check.

Testing status & QA

Added a UnityTest to validate that setting InputSystemUIInputModule.localMultiPlayerRoot to null allows full UI navigation as expected.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

• Complexity: low
• Halo Effect: low

Comments to reviewers

As localMultiPlayerRoot is having its own null check, we have removed the PlayerRoot null check in InitializePlayerRoot().

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

After merge:

• Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

[unity-cla-assistant]

All committers have signed the CLA.

[codecov-github-com]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop    #2222   +/-   ##
========================================
  Coverage    68.14%   68.15%           
========================================
  Files          367      367           
  Lines        53662    53661    -1     
========================================
+ Hits         36570    36572    +2     
+ Misses       17092    17089    -3     

Flag	Coverage Δ
linux_2021.3_pkg	5.45% <ø> (+<0.01%)	⬆️
linux_2021.3_project	70.40% <ø> (+<0.01%)	⬆️
linux_2022.3_pkg	5.23% <ø> (ø)
linux_2022.3_project	65.24% <ø> (+<0.01%)	⬆️
linux_6000.0_pkg	5.23% <ø> (ø)
linux_6000.0_project	68.04% <ø> (+<0.01%)	⬆️
linux_6000.2_pkg	5.23% <ø> (ø)
linux_6000.2_project	68.04% <ø> (-0.01%)	⬇️
linux_trunk_pkg	5.24% <ø> (ø)
linux_trunk_project	68.05% <ø> (+0.01%)	⬆️
mac_2021.3_pkg	5.45% <ø> (+<0.01%)	⬆️
mac_2021.3_project	70.41% <ø> (+<0.01%)	⬆️
mac_2022.3_pkg	5.22% <ø> (ø)
mac_2022.3_project	65.27% <ø> (+<0.01%)	⬆️
mac_6000.0_pkg	5.23% <ø> (ø)
mac_6000.0_project	68.06% <ø> (+<0.01%)	⬆️
mac_6000.2_pkg	5.23% <ø> (ø)
mac_6000.2_project	68.06% <ø> (+<0.01%)	⬆️
mac_trunk_pkg	5.23% <ø> (ø)
mac_trunk_project	68.06% <ø> (+<0.01%)	⬆️
win_2021.3_pkg	5.45% <ø> (+<0.01%)	⬆️
win_2021.3_project	70.48% <ø> (+<0.01%)	⬆️
win_2022.3_pkg	5.23% <ø> (ø)
win_2022.3_project	65.34% <ø> (+<0.01%)	⬆️
win_6000.0_pkg	5.23% <ø> (ø)
win_6000.0_project	68.13% <ø> (+<0.01%)	⬆️
win_6000.2_pkg	5.23% <ø> (ø)
win_6000.2_project	68.13% <ø> (+<0.01%)	⬆️
win_trunk_pkg	5.23% <ø> (ø)
win_trunk_project	68.13% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...m/InputSystem/Plugins/UI/MultiplayerEventSystem.cs	100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[LeoUnity]

Looks good to me, adding Joao that might have a bit more insights on this area than me, and Paulius as the area QA

[ekcoh]

Change looks good to me, thanks for adding the test to cover the associated use-case.

[ekcoh]

Branch needs an update based on develop and then a CI re-run to land. Seems like QA review is also pending.

[jfreire-unity]

Looks ok to me, and also good to have at least 1 test added 👍

[Pauliusd01]

@hannem-rythmos do you have any suggestions on how I should test this one? I've tried setting it to null and I'm unable to with and without the PR, I must be doing something wrong

[hannem-rythmos]

Hi @Pauliusd01 , could you please share the repro steps you tried?

[Pauliusd01]

Tried again via reflection and I guess I can set it to null, not sure if there's anything "real" for me to check besides that