feat: add discount at checkout feature#28
Open
dmoonat wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Open
feat: add discount at checkout feature#28dmoonat wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
dmoonat wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Conversation
kthota-g
suggested changes
Jan 23, 2026
Contributor
kthota-g
left a comment
There was a problem hiding this comment.
@dmoonat thanks for the changes. Discount is supported via an Extension and is specified here https://ucp.dev/latest/specification/discount/
Once the discount codes are applied, changes are needed to update the Checkout object with Discount related attributes to conform to the spec.
| isinstance(checkout, FulfillmentCheckout) | ||
| and checkout.fulfillment is None | ||
| ) and not any( | ||
| line_item.item.id == "donation" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the functionality to apply discount codes during the checkout process in the business agent. This includes backend logic for calculating discounts, agent tool integration, and schema updates.
Key Changes:
Agent Logic (agent.py):
Store Implementation (store.py):
Configuration & Data:
README.md: