fix: update discovery profile specification links#7
Open
0x8000-0000 wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Open
fix: update discovery profile specification links#70x8000-0000 wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
0x8000-0000 wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Conversation
costinsin
approved these changes
Jan 12, 2026
oluwatimio
reviewed
Jan 14, 2026
| spec: 'https://ucp.dev/specs/shopping', | ||
| spec: 'https://ucp.dev/specification/shopping', | ||
| rest: { | ||
| schema: 'https://ucp.dev/services/shopping/openapi.json', |
There was a problem hiding this comment.
Looks like this is also outdated in main branch @0x8000-0000 also get a 404 here. Should it be https://ucp.dev/services/shopping/rest.openapi.json?
Contributor
There was a problem hiding this comment.
Yes, please update the schema URI here to https://ucp.dev/services/shopping/rest.openapi.json
Thanks @oluwatimio for catching it!
Contributor
Author
There was a problem hiding this comment.
@jingyli - then should https://github.com/Universal-Commerce-Protocol/samples/blob/main/rest/python/server/routes/discovery_profile.json#L7 be updated too?
Contributor
There was a problem hiding this comment.
Yes, I have just created #29 to make the update, PTAL!
0x8000-0000
force-pushed
the
bugfixes
branch
2 times, most recently
from
8b10764 to
c6a5343
Compare
Outdated links pointing to 'https://ucp.dev/specs/shopping' were returning 404 errors. This change updates all discovery profiles and documentation in the samples repository to use the current 'https://ucp.dev/specification' structure. - rest/python/server: Updated 'discovery_profile.json' and 'README.md'. - rest/python/client: Regenerated 'happy_path_dialog.md' by running the updated server and client. - rest/nodejs: Updated discovery service logic in 'discovery.ts'. - a2a/business_agent: Updated 'ucp.json' and 'agent_card.json' data files. - a2a/chat-client: Updated 'agent_profile.json'. These updates ensure that discovery responses from sample implementations point to valid, working specification pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outdated links pointing to 'https://ucp.dev/specs/shopping' were returning 404 errors. This change updates all discovery profiles and documentation in the samples repository to use the current 'https://ucp.dev/specification' structure.
These updates ensure that discovery responses from sample implementations point to valid, working specification pages.