Skip to content

Conversation

@gastonfournier
Copy link
Contributor

@gastonfournier gastonfournier commented Nov 26, 2025

About the changes

  • Migrates HTTP requests from make-fetch-happen to ky, keeping proxy/agent support and shared retry behavior for 408/429/5xx responses.
  • Adds a small ky helper (src/http-client.ts), updates request/bootstrap code to use it, and keeps errors surfaced as responses.
  • Upgrades nock for native fetch mocking, removes make-fetch-happen deps, and tunes TypeScript config for DOM types. Tests adjusted for new retry behavior and lint fixes included.
  • CJS + ky: ky is ESM-only; we kept the project CommonJS by dynamically importing ky in src/http-client.ts and passing that instance to callers. No "type": "module" change; no static ky imports in CJS modules.

@gastonfournier gastonfournier added the 🤖👤 mostly-ai LLM-led with human assistance label Nov 26, 2025
@gastonfournier gastonfournier self-assigned this Nov 26, 2025
@gastonfournier gastonfournier changed the title feat: replace make-fetch-happen with ky and refresh tests/deps feat!: replace make-fetch-happen with ky and refresh tests/deps Nov 26, 2025
@gastonfournier gastonfournier moved this from New to Bots in Issues and PRs Nov 27, 2025
@gastonfournier gastonfournier moved this from Bots to Todo in Issues and PRs Nov 27, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19823188719

Details

  • 31 of 33 (93.94%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 89.674%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/request.ts 21 23 91.3%
Totals Coverage Status
Change from base Build 19821896389: 0.03%
Covered Lines: 1190
Relevant Lines: 1277

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖👤 mostly-ai LLM-led with human assistance

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants