Support Blackwell GPUs in setup - #5
Draft
Arison591 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #2.
ANIGEN_CUDA_CAPABILITYas a fallback for environments where GPU discovery is unavailableTORCH_CUDA_ARCH_LISTandFLASH_ATTN_CUDA_ARCHSfor local extension builds and reject PyTorch versions older than 2.7 on BlackwellPyTorch 2.7 is the first release with Blackwell support and CUDA 12.8 wheels: https://pytorch.org/blog/pytorch-2-7/
Why
The current CUDA-major-only selection installs PyTorch 2.4.0 from the cu121 index for every CUDA 12 GPU. That wheel does not contain support for the RTX 50-series
sm_120target, so the default setup path is not usable on Blackwell.Validation
tests/test_setup_blackwell.sh— passed (Blackwell selection, legacy selection, and old-Torch rejection)bash -n setup.sh tests/test_setup_blackwell.sh— passedshellcheck -e SC2166 setup.sh tests/test_setup_blackwell.sh— passed (SC2166is from a pre-existing conditional)spconv-cu121==2.3.8minimalSubMConv3dCUDA forward — passed, output shape(4, 5)flash-attn==2.8.3flash_attn_funcCUDA forward — passed with finite output, input shape(2, 128, 8, 64)I did not download the multi-GB AniGen checkpoints or run a full mesh-generation workflow.