Skip to content

Conversation

@xiangzhai
Copy link

Hi,

I want to port vectorscan AKA hyperscan for LoongArch Architecture.

Passed unit-internal test:

[==========] 14040 tests from 73 test cases ran.
[  PASSED  ] 14040 tests.

Passed unit-hyperscan test:

[==========] 3746 tests from 33 test cases ran.
[  PASSED  ] 3746 tests.

Thanks,
Leslie Zhai

markos and others added 30 commits December 6, 2021 18:38
…pport

Minor changes to enable compilation on Mac M1
…package-to-separate-branch

keep debian folder in a separate branch
Fix word boundary assertions under C++20
Fix all ASAN issues in vectorscan
@xiangzhai
Copy link
Author

Hi @markos

Could you review the patch?

Thanks,
Leslie Zhai

@markos
Copy link

markos commented Dec 12, 2023

@xiangzhai not until lsxintrin.h is in a package in Debian for either clang or gcc. Until that happens, I cannot merge LSX support. I just tested gcc-13 and clang-17, they still don't have that file in Debian packages.

@markos
Copy link

markos commented Dec 13, 2023

I added some review comments, which should be easy to fix until we can actually do a proper review when compiler support arrives. Thanks for your patience in this.

@markos markos modified the milestones: 5.4.12, 5.4.13 Dec 13, 2023
Move ARCH_C_FLAGS and ARCH_CXX_FLAGS to LoongArch respective cmake file.
Move vpmax_loongarch to loongarch64/simd_utils.h.
@xiangzhai
Copy link
Author

Hi @markos

Thanks for your careful review!

I updated my patch as your suggestion.

Thanks,
Leslie Zhai

@xiangzhai xiangzhai requested a review from markos December 14, 2023 01:45
@xiangzhai
Copy link
Author

Hi @markos

not until lsxintrin.h is in a package in Debian for either clang or gcc. Until that happens, I cannot merge LSX support. I just tested gcc-13 and clang-17, they still don't have that file in Debian packages.

Please update to install clang-18, there is lsxintrin.h for LLVM 18 now and rust SIMD intrinsics for LoongArch merged :)

Thanks,
Leslie Zhai

@markos
Copy link

markos commented Feb 29, 2024

Hi @xiangzhai
I will have to unbrick my 3a5000 system as I tried to flash the wrong uefi image and it doesn't boot now. I will do that in the next weeks and reconfigure the system to use a more modern compiler. If I can make it work, I will merge this PR.
Thank you again for your contribution!

@xiangzhai
Copy link
Author

I will have to unbrick my 3a5000 system as I tried to flash the wrong uefi image and it doesn't boot now.

https://github.com/loongson/Firmware/tree/main/5000Series/PC

@markos
Copy link

markos commented Feb 29, 2024

I will have to unbrick my 3a5000 system as I tried to flash the wrong uefi image and it doesn't boot now.

https://github.com/loongson/Firmware/tree/main/5000Series/PC

Indeed, that's where I got it from, I just forgot to download the 'raw' binary. In any case, I need to figure out how to connect a JTAG or similar adaptor and upload the UEFI image using SPI. Currently it just gives a constant beep and fails to do anything else -no UEFI Shell/BIOS screen or anything else.

@xiangzhai
Copy link
Author

Hi @markos

Could you try qemu system loongarch64 if your working environment was broken please?

Thanks,
Leslie Zhai

@markos
Copy link

markos commented Mar 16, 2024

Even if it builds on qemu -which is not something I have the time to do- we would not merge the PR as we would not be able to support it in our CI. It is in the immediate plans to either fix the system or get a new one. Just be patient please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request wishlist Something that would be nice to have but not a priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new architecture support: Loongson LSX