-
Notifications
You must be signed in to change notification settings - Fork 857
VCST-4327: Upgrade to .NET 10 #2965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
feat: Upgrade to .NET 10
docs/release-information/update-to-version-3-1000/vc-net10-update.ps1
Outdated
Show resolved
Hide resolved
| if (!parameter.Style.HasValue) | ||
| var parameter = operation.Parameters[i]; | ||
| if (parameter.In == ParameterLocation.Query | ||
| && parameter.Schema.Type == JsonSchemaType.Array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Potential null reference on parameter Schema access
The code accesses parameter.Schema.Type without null checking parameter.Schema first. In OpenAPI v3, the Schema property can be null when Content is used instead for parameter definition. This will throw a NullReferenceException if a parameter uses content-based schema definition rather than direct schema assignment.
…ityFrameworkCore.Design
|
| <PackageReference Include="GenFu" Version="1.6.0" /> | ||
| <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="6.0.0" /> | ||
| <PackageReference Include="BenchmarkDotNet" Version="3.1000.0" /> | ||
| <PackageReference Include="GenFu" Version="3.1000.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Invalid NuGet package versions cause build failure
The BenchmarkDotNet and GenFu packages have version "3.1000.0" which does not exist on NuGet. The actual latest versions are around 0.15.x for BenchmarkDotNet and 1.6.x for GenFu. These invalid versions were likely incorrectly applied by the update script and will cause NuGet restore to fail when building the benchmark project.



Description
feat: Upgrade to .NET 10
References
QA-test:
Jira-link:
Artifact URL:
Note
Upgrade solution to .NET 10 with broad dependency updates, OpenIddict/Swagger refactors, new EF Core 10 migrations, and upgrade docs/script.
TargetFrameworktonet10.0across projects; bump version to3.1000.0and copyright to 2026.icon.pngto NuGet packages viaDirectory.Build.props.PromptValues/HasPromptValue,EnableEndSessionEndpointPassthrough,SetUserInfoEndpointUris, etc.IOpenIddictTokenStore<...>; remove custom resolver.VirtoOpenIddictEntityFrameworkCoreTokenStoreupdated to new EF Core context interface and non-async override signature.X509CertificateLoaderfor loading certs (incl. PKCS12).OpenIddictTokens.Typemax length to150.AspNetUserTokensLoginProvider/Nametonvarchar(128); drop/recreate PK accordingly; snapshot updated.SecurityDbContext(set max lengths forIdentityUserToken).Microsoft.OpenApitypes and adjust filters (ArrayInQueryParametersFilter,OptionalParametersFilter,OpenIDEndpointDescriptionFilter, etc.).EnumSchemaFilter; update tag/module metadata handling; mapobjecttoJsonSchemaType.Object.KnownIPNetworks.Clear().appsettings.json: comment out SQL ServerCompatibilityLevel.docs/release-information/update-to-version-3-1000/...andvc-net10-update.ps1script..platform-error-bar .closesizing.net10.0, test deps updated; fix assertions (countries count250).Written by Cursor Bugbot for commit 71569b7. This will update automatically on new commits. Configure here.
Image tag:
ghcr.io/VirtoCommerce/platform:3.1000.0-pr-2965-7156-net10-71569b70