Let callers supply the class hierarchy when patching a JAR - #2
Merged
Conversation
Gedochao
force-pushed
the
fix/jar-processor
branch
from
August 6, 2026 10:19
0b92665 to
012b43a
Compare
Gedochao
marked this pull request as ready for review
August 6, 2026 10:36
� Conflicts: � build.sbt � cli/src/main/scala/sloth/cli/Main.scala � core/src/main/scala/sloth/patching/BytecodePatcher.scala � core/src/main/scala/sloth/patching/ClassLoaderClassWriter.scala
…ynamic Class.forName, which fails under GraalVM without reflection metadata. Co-authored-by: Cursor <cursoragent@cursor.com>
Gedochao
force-pushed
the
fix/jar-processor
branch
from
August 10, 2026 11:32
012b43a to
f6324ad
Compare
Gedochao
force-pushed
the
fix/jar-processor
branch
from
August 10, 2026 11:32
f6324ad to
e18b1f6
Compare
lbialy
approved these changes
Aug 10, 2026
lbialy
left a comment
lbialy
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed extensively with the author, the concept is correct for the use case (native-image compilation). There are some gotchas but reporting of unresolvable classes is the correct choice for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1