Merged
Conversation
fangsmile
approved these changes
Apr 7, 2026
There was a problem hiding this comment.
Pull request overview
This pull request updates package metadata to reflect the correct UMD bundle filenames intended for CDN (unpkg) consumption across the VTable monorepo packages, and fixes a misconfigured UMD bundle name/output in vtable-search.
Changes:
- Update multiple packages’
unpkgFilesentries to point to thedist/*.jsanddist/*.min.jsUMD outputs. - Add missing
unpkg/unpkgFilesmetadata for@visactor/vtable-editors. - Fix
@visactor/vtable-searchUMD config (nameandumdOutputFilename) to produce/search undervtable-searchrather thanvtable-export.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/vtable/package.json | Point unpkgFiles to dist/vtable(.min).js instead of the old build/es5/index.js path. |
| packages/vtable-sheet/package.json | Include both dist/vtable-sheet.js and dist/vtable-sheet.min.js in unpkgFiles. |
| packages/vtable-search/package.json | Correct unpkgFiles to dist/vtable-search(.min).js. |
| packages/vtable-search/bundler.config.js | Fix UMD global name and output filename to VTable.search / vtable-search. |
| packages/vtable-plugins/package.json | Include both dist/vtable-plugins.js and dist/vtable-plugins.min.js in unpkgFiles. |
| packages/vtable-gantt/package.json | Include both dist/vtable-gantt.js and dist/vtable-gantt.min.js in unpkgFiles. |
| packages/vtable-export/package.json | Correct unpkgFiles to dist/vtable-export(.min).js (instead of vtable-exporter.js). |
| packages/vtable-editors/package.json | Add unpkg / unpkgFiles entries for dist/vtable-editors(.min).js. |
| packages/vtable-calendar/package.json | Correct unpkgFiles to dist/vtable-calendar(.min).js (instead of vtable-exporter.js). |
| packages/react-vtable/package.json | Include both dist/react-vtable.js and dist/react-vtable.min.js in unpkgFiles. |
| packages/openinula-vtable/package.json | Remove unpkg / unpkgFiles metadata (package does not build UMD per current bundler config). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough