Add tags to all settings applied only in desktop view - #116
Open
PeeterPaal wants to merge 2 commits into
Open
PeeterPaal wants to merge 2 commits into
PeeterPaal wants to merge 2 commits into
Conversation
pxska
approved these changes
Oct 18, 2022
pxska
left a comment
pxska
left a comment
Contributor
There was a problem hiding this comment.
Once we've also added the translation – looks good!
I also thought about using a mobile/desktop icon rather than a piece of text, but I guess text is more obvious.
pxska
suggested changes
Oct 25, 2022
pxska
left a comment
pxska
left a comment
Contributor
There was a problem hiding this comment.
As we might want to consult with the designer here about the exact placement & size of the icon, I'm going to mark this as red as of right now.
| </svg> | ||
|
|
||
| {%- capture "desktop-icon" -%} | ||
| <svg width="24" height="24" class="mar_l-4"><use href="#ico-desktop"></use></svg> |
Contributor
There was a problem hiding this comment.
I would probably make the width and height values the same value as the container's line-height (which in this case is 22px), because it might look more natural that way. We might want to consult with the designer here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help differentiate settings that are only applied in desktop view, add a "desktop" icon to all such settings.
Closes #112
Tag is added to following settings:
Front page header
Navigation
Blog layout
Block settings