Skip to content

feat(spec/ext) specify getWallet/onPayment#664

Merged
asurkov merged 2 commits into
mainfrom
onpayment
May 13, 2026
Merged

feat(spec/ext) specify getWallet/onPayment#664
asurkov merged 2 commits into
mainfrom
onpayment

Conversation

@asurkov
Copy link
Copy Markdown
Member

@asurkov asurkov commented May 1, 2026

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 1, 2026

Deploy Preview for webmonetization-preview ready!

Name Link
🔨 Latest commit 686a266
🔍 Latest deploy log https://app.netlify.com/projects/webmonetization-preview/deploys/69fdfd7ad17bb100087ac10e
😎 Deploy Preview https://deploy-preview-664--webmonetization-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@asurkov asurkov requested a review from sidvishnoi May 1, 2026 17:01
@asurkov asurkov self-assigned this May 1, 2026
Comment thread specification/extensions-api/section/types.html Outdated
Comment thread specification/extensions-api/section/types.html Outdated
Comment thread specification/extensions-api/section/types.html Outdated
Copy link
Copy Markdown
Contributor

@meyerweb meyerweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts on first read.

Comment thread specification/extensions-api/section/events.html
Comment thread specification/extensions-api/section/types.html
Comment thread specification/extensions-api/section/types.html
Comment thread specification/extensions-api/section/types.html Outdated
Comment thread specification/extensions-api/section/types.html Outdated
Comment thread specification/extensions-api/section/types.html Outdated
Comment thread specification/extensions-api/section/types.html Outdated
Comment on lines +70 to +71
<code>true</code> when the stored access token is invalid and the
wallet must be reconnected.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when remaining budget is too low? Do we set needsReconnect then as well?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing right now I suspect, needsReconnect is set on the user wallet response, current implementation doesn't guess about reasons.

@asurkov asurkov merged commit 4f0ebea into main May 13, 2026
7 checks passed
@asurkov asurkov deleted the onpayment branch May 13, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants