Skip to content

Conversation

@breity
Copy link
Member

@breity breity commented Jan 28, 2026

Changes

  • Don't allow Choices bucket in Match summary display to break across columns. Wrapping to multiple columns was making the display difficult to read.
  • Limit Choices bucket to 3 visible items by default and add a "Show more" link, like we do with the other buckets.

Before:
Screenshot 2026-01-28 at 3 32 27 PM

After:
Screenshot 2026-01-28 at 3 34 39 PM

Test

  • Make sure Match summary displays still in the grading tool.
  • Make sure Choices bucket limits to 3 visible items and that "Show more" and "Show less" links toggle the rest of the items.

fixes #2261

@breity breity self-assigned this Jan 28, 2026
@qltysh
Copy link

qltysh bot commented Jan 28, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. AwsBedRockService isn't related to this PR, but it's fine to include. We should parameterize the model string.

@breity
Copy link
Member Author

breity commented Jan 29, 2026

@hirokiterashima Ah, sorry. Didn't mean to include the AwsBedRockService for this PR. I'll revert since it's not related.

I'm thinking it might make sense to switch to Gemma, though, since it seemed to have a bit more current info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

style(Match Summary): bucket wrapping

3 participants