Fix playlist proxy to use flowsheet table instead of deleted album_metadata#306
Closed
jakebromberg wants to merge 1 commit intomainfrom
Closed
Fix playlist proxy to use flowsheet table instead of deleted album_metadata#306jakebromberg wants to merge 1 commit intomainfrom
jakebromberg wants to merge 1 commit intomainfrom
Conversation
Replace album_metadata table lookups with flowsheet table queries for artwork enrichment. The album_metadata table is being removed in #305; the flowsheet table now has artwork_url inline. Uses the same normalized key-based matching pattern but queries flowsheet directly.
Member
Author
|
Changes folded into #305 — the playlist proxy rewrite needs to ship with the metadata table removal to avoid breaking the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flowsheettable's inlineartwork_urlinstead of the deletedalbum_metadatatablealbum_metadatatableDepends on #305 (must merge first).
Test plan
npm run test:unit— playlist proxy tests pass (22 tests, verified locally)