fix: disable secure cookie flag in local dev and harden JWT payload#308
Open
jakebromberg wants to merge 2 commits intomainfrom
Open
fix: disable secure cookie flag in local dev and harden JWT payload#308jakebromberg wants to merge 2 commits intomainfrom
jakebromberg wants to merge 2 commits intomainfrom
Conversation
added 2 commits
April 6, 2026 07:28
The session cookie's `secure` flag was hardcoded to `true`, which prevented browsers from storing cookies over plain `http://localhost`. This broke login redirect in local development because the sign-in API succeeded but the session was never established. Also adds error handling to the JWT `definePayload` function so a database failure during member role lookup degrades gracefully instead of returning a 500, and switches from raw SQL template to `eq()` for type safety. Improves the error handler to include request method and URL in log output for easier debugging.
Add method and url to mock request object and update the expected console.error call to include the request context prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Securecookie flag in non-production environments so session cookies work overhttp://localhostdefinePayloadmember role query so DB failures degrade gracefully instead of 500ingsqltemplate to type-safeeq()Closes #307
Test plan
http://localhost:3000with test credentials — session cookie should be set and redirect to dashboard should workSecureflag is NOT present on the session cookie in local devSecureflag IS present whenNODE_ENV=production[METHOD /url]prefix