Repository navigation
feat: add support for C# - #206
Merged
Merged
Conversation
Contributor
Author
|
Ah, I just noticed #174 as well. Looks like that has stagnated and is less comprehensive though, so I think this PR probably supersedes that. |
Owner
|
Thank you for your contribution! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds fairly comprehensive support for C#. Some of the
target_nodeshandling could be considered overkill and I wouldn't be opposed to trimming them if there are objections, but there's at least a full test suite showing that they all work.Note the change to
tests/minimal.luato map thecsfiletype to thec_sharpparser. I think that's only necessary because nvim-treesitter's mapping isn't loaded during testing, and this seemed like the easiest way to work around it. It seems that some of the tests that are failing (at least for me) on main are related to this as well e.g. the bash/sh mapping is also missing. Let me know if you want to handle this some other way like trying to source the nvim-treesitter mapping directly.