Revert "Stub out all imports in ctor-eval" #8137
Merged
+68
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bc7632d.
Member
|
We don't need to quickly revert this - but up to you. If you have time to find a fix today, that seems fine to me. If it would wait several days, then a revert would make more sense to me. |
Member
Author
|
Got it, it should be an easy fix. Let me give it a try |
Member
Author
|
I wasn't able to get to the fix today. We can go ahead and merge this and I'll roll forward later. |
tlively
approved these changes
Dec 17, 2025
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
The fix turns out to be trickier than expected because imports with the same name may have incompatible types. JS can make instantiation succeed even in these cases, so we need to figure out how to make instantiation succeed when we interpret modules with such imports as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8115
This causes the fuzzer to fail when an import is repeated: #8115 (comment). Will revert and re-introduce this later with a fix.