Print failed test results at the end for the spec test suite #8154
+40
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenfontanella
force-pushed
the
failed-stdouts
branch
from
6925ad4 to
8f2f91d
Compare
sbc100
approved these changes
Dec 21, 2025
| ''' | ||
| Returns (bool, str) where the first element is whether the test was | ||
| successful and the second is the combined stdout and stderr of the test. | ||
| ''' |
Member
There was a problem hiding this comment.
The standard format for docstrings is to use tripple-double-quotes, and to include the first line of text on the opening line.
| help='Disables running the torture testcases.') | ||
| parser.add_argument( | ||
| '--abort-on-first-failure', dest='abort_on_first_failure', | ||
| '--abort-on-first-failure', "--fail-fast", dest='abort_on_first_failure', |
Member
There was a problem hiding this comment.
Single quotes here.
Also, I think we can just remove the old name here... the number folks who run this script is small enough we don't need to worry about back compat.
Also, you can use argparse.BooleanOptionalAction here maybe?
| if not failed_stdouts: | ||
| return | ||
|
|
||
| with red_stdout(): |
Member
There was a problem hiding this comment.
I would maybe combine theese:
if failed_stdouts:
with red_stdout():
...
I guess early return is good.. but in this case there is only one following block.
Member
|
Another nice addition (ideas for followups).
Even better, only print this single-line status (i.e. no stdout from the test) unless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shared.options.abort_on_first_failurework with the spec test suite and add aliases for --fail-fast and --no-fail-fastactualisn't defined).With
--no-fail-fast:With
--fail-fast(the default):