Open
Conversation
Contributor
|
@SPY . So if I export a function like: And call Effectively taking the more precise type of My understanding from the last in-person CG meeting is that this is not the behavior we want. This would mean that anyone reading We should instead throw an exception here. |
Collaborator
Author
|
@eqrion I think I misunderstood in-person discussion, thanks for correction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is supposed to address issues #20 and #30 by replacing
funcrefandexternrefwith more detailed{ref: HeapType, nullable: bool}dictionary.WebAssembly.Function.type()will return{ref: 'any', nullable}for any GC type, butnew WebAssembly.Functionwill throw an error if it will be called with a signature containing{ref: 'any', nullable}types.This behaviour is supposed to be replaced with more detailed support in the future under cover of GC subgroup.