fix(admin): mark batch refresh 401 failures as error#2943
Open
Luminet2023 wants to merge 2 commits into
Open
Conversation
Contributor
|
All contributors have signed the CLA. ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更
batch-refresh单账号刷新失败后,按错误对应的 HTTP 状态码判断是否需要自动标记账号错误。401 Unauthorized时调用AdminService.SetAccountError,由既有仓储逻辑写入status=error、error_message并关闭调度。errors明细,不修改账号状态。HTTP 401错误识别。背景
/api/v1/admin/accounts/batch-refresh原先只汇总刷新失败的账号 ID 和错误信息,不会改变账号状态。现在刷新失败只有在上游语义为 401 时才会自动进入 error 状态,避免临时网络错误、非 OAuth 账号等非授权失败误伤账号。验证
go test -- -tags=unit ./internal/handler/admin -run TestBatchRefresh -count=1go test -- -tags=unit ./internal/handler/admin -count=1