[codex] fix OpenAI Codex primary 5h quota reset#2980
Draft
anzhiyu-c wants to merge 1 commit into
Draft
Conversation
Contributor
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA). To sign, please reply with the following comment:
You only need to sign once — it will be valid for all your future contributions to this project. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
4bc57bc to
bfd2e35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
primary_used_percent=0).Root cause
When OpenAI sends the 5h Codex limit in the primary quota window (
x-codex-primary-window-minutes: 300),x-codex-primary-used-percentis already a used percentage. The previous normalization always calculated100 - rawfor the canonical 5h used percent, so a primary 5h value of0became100. That can make an account with available 5h quota display as fully exhausted.The same inversion also affects reset selection when primary=5h is exhausted, because the canonical 5h used percent may no longer reflect the actual upstream limit state.
Validation
go test -tags=unit ./internal/service -run 'TestCalculateOpenAI429ResetTime|TestOpenAIUpdateCodexUsageSnapshotFromHeaders|TestNormalizedCodexLimits'\n-go test -tags=unit ./internal/service