Skip to content

fix: close store in read_as_dask correctly #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WeilerP merged 1 commit into from
Apr 28, 2026
Merged

fix: close store in read_as_dask correctly #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/fancypackage/io/_dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
from collections.abc import Generator
from itertools import chain
from pathlib import Path

import zarr
from zarr import Group as ZarrGroup
from zarr.storage import StoreLike

from anndata import AnnData
from anndata.experimental import read_elem_lazy
Expand Down Expand Up @@ -35,7 +35,7 @@ def _get_entries(group: ZarrGroup, level: str, entries: str | list[str] | None)


def read_as_dask(
store: Path | str,
store: StoreLike,
layers: str | list[str] | None = None,
obsm_keys: str | list[str] | None = None,
varm_keys: str | list[str] | None = None,
Expand Down Expand Up @@ -88,6 +88,6 @@ def read_as_dask(
for varm_key in varm_keys:
adata.varm[varm_key] = read_elem_lazy(group[f"varm/{varm_key}"])

store.close()
group.store.close()

return adata
Loading